chore(authorship): remove dead VirtualAttributions::add_pathspec#1334
Open
jwiegley wants to merge 1 commit into
Open
chore(authorship): remove dead VirtualAttributions::add_pathspec#1334jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
67ffe40 to
dc439a7
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
6037a11 to
97d01b8
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
2 times, most recently
from
7845736 to
f1f74c3
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
97d01b8 to
7554d6e
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
f1f74c3 to
cc52733
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
7554d6e to
7be185c
Compare
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
2 times, most recently
from
f5ad53c to
e75f51e
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
7d45688 to
e55b8b5
Compare
add_pathspec was a thin wrapper around add_pathspecs_concurrent with zero callers — all call sites use the concurrent variant directly. Also removes the now-unnecessary #[allow(dead_code)] suppression from get_attributions, which has active callers in integration tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/authorship-add-pathspec-cleanup
branch
from
e75f51e to
96fb3fd
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
e55b8b5 to
176e66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_pathspec was a thin wrapper around add_pathspecs_concurrent with zero callers — all call sites use the concurrent variant directly. Also removes the now-unnecessary #[allow(dead_code)] suppression from get_attributions which has active callers in integration tests.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code