chore(api): remove dead ApiClient factory methods and metrics helper#1331
Open
jwiegley wants to merge 1 commit into
Open
chore(api): remove dead ApiClient factory methods and metrics helper#1331jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
from
e50b7c0 to
b441368
Compare
jwiegley
force-pushed
the
dc/api-client-cleanup
branch
from
207a9b5 to
56d46fb
Compare
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
from
b441368 to
7b0fed0
Compare
jwiegley
force-pushed
the
dc/api-client-cleanup
branch
2 times, most recently
from
398e699 to
5b6c496
Compare
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
from
7b0fed0 to
254052f
Compare
ApiContext::without_auth, ApiContext::with_auth, and ApiClient::context_mut had zero callers — all production code reaches the API via the single ApiContext::new constructor. Remove them along with MetricsUploadResponse::successful_indices which was similarly never consulted by the upload response handler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/api-client-cleanup
branch
from
5b6c496 to
7f15079
Compare
jwiegley
force-pushed
the
dc/api-bundle-cas-cleanup
branch
from
254052f to
1f6cf1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove ApiContext::without_auth, with_auth, and ApiClient::context_mut — zero callers in all production code and tests. All API access uses the single ApiContext::new constructor. Also removes MetricsUploadResponse::successful_indices which was never consulted by the upload response handler.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code