refactor: remove any and as throughout codebase#1323
Open
jescalada wants to merge 56 commits intofinos:mainfrom
Open
refactor: remove any and as throughout codebase#1323jescalada wants to merge 56 commits intofinos:mainfrom
any and as throughout codebase#1323jescalada wants to merge 56 commits intofinos:mainfrom
Conversation
…ttestation definition
…elds, remove any in src/proxy/routes/index
Sets stub types to (`ReturnType<typeof vi.fn>`) to remove the any type
…for req and stubs
…/jescalada/git-proxy into 1174-remove-any-and-as-ts-wrapup
…y, jwtAuthHandler)
… for edge case tests
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Contributor
Author
|
@kriswest Should be ready to review now 😃 |
Contributor
Author
|
By the way, I'm not sure which missing coverage lines aren't already dealt with in #1356, so I suggest ignoring the lost coverage here and dealing with the aftermath in that PR instead. |
kriswest
reviewed
Feb 16, 2026
Contributor
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Another monster contribution, much appreciated. I've left a handful of comments for you to look at (I think a couple of removed test cases are still needed and a util function could go in for handling error message extraction - which could allow us to turn on stack traces) - however the majority LGTM.
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
… match original ones
…ry proxy variable
…or tab identifier
Contributor
Author
|
@kriswest Ready for a final look! |
Contributor
|
@jescalada trying to fit in a final pass, but you've developed a whole load of conflicts unfortunately. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1174.