Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 81.39% 81.78% +0.39%
==========================================
Files 67 67
Lines 4741 4766 +25
Branches 819 827 +8
==========================================
+ Hits 3859 3898 +39
+ Misses 867 852 -15
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
left a comment
There was a problem hiding this comment.
Tested the core flow and edge cases, LGTM!
Just a heads up, a fair bit of the attestation endpoint logic has been improved in #1323. Attestation-related classes have been added as well. I'm able to handle conflicts and extra changes to the /reject endpoint in that PR - it'd be great if you could take a look and make sure things still work as expected!
|
@jescalada happy to check out #1323 |
|
@andypols Thank you! I'll ping you after fixing up the conflicts, likely tomorrow... |
Closes #605.
Summary
Right now, reviewers can reject a push without leaving any context, and push authors can’t tell who rejected it or why. This PR makes rejections explicit by requiring a reason and recording the rejecting reviewer, then surfaces that information in the UI.
UI
Attestationmodal) that requires a reviewer to enter a reason before a rejection can be submitted.PushDetailsby extracting components to reduce complexity and improve readability/maintainability.Backend
Rejectiontype containingreviewer,reason, andtimestamp.