Repository navigation
Fix tests to support Docker 29 - #98
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The event-field change breaks functional-test compatibility with supported Docker API versions before v1.22.
1 open finding
What changed in this PR
Updates functional tests for Docker 29’s event schema while retaining existing event-count handling.
Changes:
- Uses the
Actionevent field instead of deprecatedstatus. - Documents Docker versions associated with event-count changes.
| File | Description |
|---|---|
tests/FunctionalClientTest.php |
Updates event assertions and version comments. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes the tests to support Docker 29. Docker 29 no longer reports the deprecated
statusfield for events, so the tests now use theActionfield instead, which has been available since Docker 1.10 and is already used by the network test. While at it, the test comments now name the exact Docker versions that changed the number of events.Our CI still runs Docker 28, so it is not affected yet, but GitHub plans to update its runners to Docker 29 (actions/runner-images#14105). The library itself is not affected, as it passes events through unchanged.
Builds on top of #92 and #80
Refs moby/moby#50832 and actions/runner-images#14105