Skip to content

Commit 20b91af

Browse files
authored
Merge pull request #98 from clue-labs/docker29-tests
Fix tests to support Docker 29
2 parents a21ad6f + 4d15c32 commit 20b91af

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

‎tests/FunctionalClientTest.php‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,18 +92,18 @@ public function testCreateStartAndRemoveContainer()
9292
$ret = \React\Async\await($promise);
9393
assert(is_array($ret));
9494

95-
$status = array(); // array_column($ret, 'status'); // PHP 5.5+
95+
$actions = array(); // array_column($ret, 'Action'); // PHP 5.5+
9696
foreach ($ret as $one) {
97-
$status[] = $one['status'];
97+
$actions[] = $one['Action'];
9898
}
9999

100-
// expect 4 events as of ~2021, 5 in earlier versions
101-
if (count($status) === 4) {
100+
// expect 4 events as of Docker 20.10 (2020), 5 in earlier versions
101+
if (count($actions) === 4) {
102102
// start, die, attach, destroy
103-
$this->assertEquals(array('start', 'die', 'attach', 'destroy'), $status);
103+
$this->assertEquals(array('start', 'die', 'attach', 'destroy'), $actions);
104104
} else {
105105
// expects "start", "attach", "kill", "die", "destroy" events
106-
$this->assertEquals(array('start', 'attach', 'kill', 'die', 'destroy'), $status);
106+
$this->assertEquals(array('start', 'attach', 'kill', 'die', 'destroy'), $actions);
107107
}
108108
}
109109

@@ -484,7 +484,7 @@ public function testCreateConnectDisconnectAndRemoveNetwork()
484484
$actions[] = $one['Action'];
485485
}
486486

487-
// expect 2 events as of ~2025, 3 in earlier versions
487+
// expect 2 events as of Docker 28 (2025), 3 in earlier versions
488488
if (count($actions) === 2) {
489489
// expects only "create" and "destroy" events (no "connect" / "disconnect" because we don't start the container)
490490
$this->assertEquals(array('create', 'destroy'), $actions);

0 commit comments

Comments
 (0)