Skip to content

feature: adding stateful visitor for dijkstra and astar - #637

Merged
Becheler merged 1 commit into
boostorg:developfrom
Becheler:feature/adapter-visitor-std-ref
Oct 9, 2026
Merged

Becheler merged 1 commit into
boostorg:developfrom
Becheler:feature/adapter-visitor-std-ref

Conversation

@Becheler

@Becheler Becheler commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Important

New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.

Motivation

Extends #614 #634 #635 #636 to new algorithms

What this PR does

gives Dijkstra and A* (and Prim for free) std::ref support

Before submitting

  • I searched for an existing PR or issue covering the same change.
  • This PR targets the develop branch.
  • My contribution is licensed under the Boost Software License 1.0.

Kind of change

Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).

  • Reformat (layout only, no token added or removed)
  • Refactor (no observable behavior change)
  • Behavior change (observable to users of the library)
  • No code change (documentation, build, CI, or tooling)

Change category

  • Bug fix
  • New algorithm or API addition
  • Deprecation or removal
  • Performance
  • Tests
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

@Becheler Becheler added api algorithm type of issue related to algorithms visitor Type of issue related to visitors labels Oct 8, 2026
@cppalliance-bot

cppalliance-bot commented Oct 8, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://637.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-09 07:26:54 UTC

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 37897867721 vs develop run 37798542960 (aab8534836).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler force-pushed the feature/adapter-visitor-std-ref branch from 97af17c to d5f8588 Compare October 8, 2026 15:09
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 37891716697 vs develop run 37798542983 (256a33d1bc).

Job Baseline After Delta
macos (clang, 14) 392 393 +1
macos (clang, 17) 391 392 +1
macos (clang, 20) 391 392 +1
ubuntu (clang-19, 14) 392 393 +1
ubuntu (clang-19, 17) 391 392 +1
ubuntu (clang-19, 20) 391 392 +1
ubuntu (clang-19, 23) 391 392 +1
ubuntu (gcc-14, 14) 345 349 +4
ubuntu (gcc-14, 17) 341 345 +4
ubuntu (gcc-14, 20) 341 345 +4
ubuntu (gcc-14, 23) 341 345 +4
windows_msvc_14_3 (msvc-14.3) 931 937 +6

@Becheler
Becheler force-pushed the feature/adapter-visitor-std-ref branch 2 times, most recently from dd4c029 to 256a33d Compare October 9, 2026 06:05
@Becheler
Becheler force-pushed the feature/adapter-visitor-std-ref branch from 256a33d to aab8534 Compare October 9, 2026 07:14
@Becheler
Becheler marked this pull request as ready for review October 9, 2026 10:11
@Becheler
Becheler merged commit a3e5d00 into boostorg:develop Oct 9, 2026
32 checks passed
@Becheler Becheler self-assigned this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm type of issue related to algorithms api visitor Type of issue related to visitors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants