Skip to content

feature: support stateful visitors for neighbor_bfs and biconnected - #639

Merged
Becheler merged 1 commit into
boostorg:developfrom
Becheler:feature/neighbor-bfs-biconnected-stateful-visitors
Oct 10, 2026
Merged

Becheler merged 1 commit into
boostorg:developfrom
Becheler:feature/neighbor-bfs-biconnected-stateful-visitors

Conversation

@Becheler

@Becheler Becheler commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Important

New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.

Motivation

Extends #614 #634 #635 #636 #637 to two new algorithms:

  • biconnected_components
  • neighbor_bfs

What this PR does

  • add std::ref support for stateful visitors
  • add required positional overload
  • add doc
  • add missing test coverage

Before submitting

  • I searched for an existing PR or issue covering the same change.
  • This PR targets the develop branch.
  • My contribution is licensed under the Boost Software License 1.0.

Kind of change

Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).

  • Reformat (layout only, no token added or removed)
  • Refactor (no observable behavior change)
  • Behavior change (observable to users of the library)
  • No code change (documentation, build, CI, or tooling)

Change category

  • Bug fix
  • New algorithm or API addition
  • Deprecation or removal
  • Performance
  • Tests
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

@Becheler Becheler self-assigned this Oct 9, 2026
@Becheler Becheler added api algorithm type of issue related to algorithms visitor Type of issue related to visitors labels Oct 9, 2026
@cppalliance-bot

cppalliance-bot commented Oct 9, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://639.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-10 10:04:35 UTC

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 38043350865 vs develop run 37951267968 (02ebe3046d).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler marked this pull request as ready for review October 9, 2026 10:14
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 38043350859 vs develop run 37951268000 (02ebe3046d).

Job Baseline After Delta
macos (clang, 14) 253 253 0
macos (clang, 17) 252 252 0
macos (clang, 20) 252 252 0
ubuntu (clang-19, 14) 253 253 0
ubuntu (clang-19, 17) 252 252 0
ubuntu (clang-19, 20) 252 252 0
ubuntu (clang-19, 23) 252 252 0
ubuntu (gcc-14, 14) 349 349 0
ubuntu (gcc-14, 17) 345 345 0
ubuntu (gcc-14, 20) 345 345 0
ubuntu (gcc-14, 23) 345 345 0
windows_msvc_14_3 (msvc-14.3) 937 937 0

@Becheler
Becheler force-pushed the feature/neighbor-bfs-biconnected-stateful-visitors branch from b46c4a4 to 02ebe30 Compare October 10, 2026 09:59
@Becheler
Becheler merged commit 422e1b9 into boostorg:develop Oct 10, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm type of issue related to algorithms api visitor Type of issue related to visitors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants