ci: run a Windows Android smoke e2e on every pull request, share setup as composite actions - #899
Merged
Merged
Conversation
…p as composite actions run-native-e2e.mjs gains --smoke: fixture, one worktree, stim start, a cold build, install, launch, readiness, stim stop, worktree remove and the cleanup checks, stopping before the second-worktree cache proof and named slots. The Windows Android job becomes a suite matrix: smoke on every push and pull request, blocking; loop added on workflow_dispatch or a windows-named pull request, as before. The pnpm/Node/install/build steps repeated across ci.yml, e2e-native.yml and windows-debug.yml move to .github/actions/setup-stim, and the Windows JDK plus system image steps to .github/actions/windows-android-sdk.
… count in the docs
This was referenced Sep 19, 2026
janicduplessis
added a commit
that referenced
this pull request
Sep 19, 2026
Fourth multi-process claim test to hit the Windows rename delete-pending limbo: a racer child exits non-zero with empty stdout, so the JSON parse in the test fails. Seen on the blocking test (windows) lane of #899.
janicduplessis
added a commit
that referenced
this pull request
Sep 19, 2026
…#883) (#903) * test: skip the device-lease race test on win32 (#883) Fourth multi-process claim test to hit the Windows rename delete-pending limbo: a racer child exits non-zero with empty stdout, so the JSON parse in the test fails. Seen on the blocking test (windows) lane of #899. * test: skip the concurrent config record test on win32 (#883) Fifth of the family, seen on the test (windows) lane of #900.
janicduplessis
added this pull request to stack #906
September 19, 2026 12:34
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #898.
A per-pull-request Windows smoke.
test/e2e/native/run-native-e2e.mjsgains--smoke: fixture, one worktree,stim start, a cold Gradle build, install, launch, readiness,stim stop,stim worktree removeand the cleanup checks. It stops before the second-worktree cache proof and the named-slots phase, so it is about 22 minutes onwindows-latestagainst 47 for the full loop, and it still exercises the paths the unit suite fakes:gradlew.batthrough cross-spawn, Metro listener discovery through netstat, the emulator andadb, and thetaskkilltree kill on stop.The Windows Android job becomes a
suitematrix.android smoke (windows)runs on every push to main and every pull request, blocking, with the driver step as its gate.android loop (windows)is added onworkflow_dispatchor a pull request from a windows-named branch, unchanged in content: its driver step keepscontinue-on-errorand the APK assertion stays its gate until #892 and #893 land. SamefromJSONselectione2e-native.ymlalready uses for its suites.Composite actions. The pnpm/Node/install/build steps were copy-pasted six times across
ci.yml,e2e-native.ymlandwindows-debug.yml; they move to.github/actions/setup-stim(inputsnode,install,build). The Windows JDK 17, capability record and system-image install move to.github/actions/windows-android-sdk, shared by the CI lane and the debug host. Thetestjob keeps its explicit build step after lint and format so the fail-early order is unchanged;runtime-floorkeeps its pinned Node pair and is untouched.docs/e2e-and-ci.mdlists the smoke suite, the Windows lanes, the debug workflow and the actions.Verification: this PR's own run exercises
setup-stimon Ubuntu and Windows andwindows-android-sdkon the Windows lane, and its branch name containswindows, so bothandroid smoke (windows)andandroid loop (windows)are scheduled.