test: skip the device-lease race and concurrent config tests on win32 (#883) - #903
Merged
Merged
Conversation
janicduplessis
changed the title
janicduplessis
marked this pull request as ready for review
September 19, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #883.
Two more multi-process claim tests hit the Windows rename delete-pending limbo on the blocking
test (windows)lane of pull requests that do not touch them:engine-device-lease.test.ts"two processes racing for one free device leave exactly one holder" (#899: a racer child throws insidetakeLease, exits non-zero with empty stdout, and the test'sJSON.parsefails) andconfig.test.ts"concurrent processes each keep their record" (#900). Both are skipped onwin32with the reason and issue in the test name, like the three skips from #886 and #891, and still run on macOS and Linux.These skips are a stopgap; #883 is the fix.