Skip to content

GUACAMOLE-2276: Update Czech translations: add options & fixes#1213

Open
Vict0rC wants to merge 1 commit into
apache:patchfrom
Vict0rC:patch
Open

GUACAMOLE-2276: Update Czech translations: add options & fixes#1213
Vict0rC wants to merge 1 commit into
apache:patchfrom
Vict0rC:patch

Conversation

@Vict0rC

@Vict0rC Vict0rC commented May 21, 2026

Copy link
Copy Markdown
Contributor

Add and update Czech localization entries:

  • introduce ERROR_CLIENT_205 and ACTION_CLOSE, add FIELD_HEADER_RECORDING_INCLUDE_CLIPBOARD in multiple sections
  • add FIELD_HEADER_FUNC_KEYS_AND_KEYPAD and its FIELD_OPTION_* values for terminals (ESC/VT100)
  • add Mac OS Roman clipboard encoding, standardize font label to "Název písma" across entries
  • adjust HELP_MOUSE_MODE_ABSOLUTE wording, and correct pluralization for INFO_NUMBER_OF_RESULTS
    Also minor whitespace/formatting fixes.
    These changes align translations with new features and improve clarity.

Add and update Czech localization entries: introduce ERROR_CLIENT_205 and ACTION_CLOSE, add FIELD_HEADER_RECORDING_INCLUDE_CLIPBOARD in multiple sections, add FIELD_HEADER_FUNC_KEYS_AND_KEYPAD and its FIELD_OPTION_* values for terminals (ESC/VT100), add Mac OS Roman clipboard encoding, standardize font label to "Název písma" across entries, adjust HELP_MOUSE_MODE_ABSOLUTE wording, and correct pluralization for INFO_NUMBER_OF_RESULTS. Also minor whitespace/formatting fixes. These changes align translations with new features and improve clarity.

@necouchman necouchman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better - just a couple of minor things.

@@ -43,7 +43,7 @@

"FIELD_HEADER_PASSWORD" : "Heslo:",
"FIELD_HEADER_PASSWORD_AGAIN" : "Heslo znovu:",
"FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Povolit zápis do existujícího záznamového souboru:",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the line is no longer being removed, but the spacing that aligns it with the line below has now been removed. It looks like that's the only change to this line - the translation appears identical, so there's no reason to change this line at all, correct?

@@ -153,7 +154,7 @@
"SECTION_HEADER_FILE_TRANSFERS" : "Přenos souborů",
"SECTION_HEADER_INPUT_METHOD" : "Metoda vstupu",

"SECTION_HEADER_MOUSE_MODE" : "Mód emulace myši",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment above - the only change to this line appears to be removal of the space that aligns the spacing with the lines above it. There's no reason to change this, as far as I can tell?

@Vict0rC

Vict0rC commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

anything else wrong?

@necouchman

Copy link
Copy Markdown
Contributor

anything else wrong?

I left a couple of comments above that I do not see having been addressed or commented on?

@Vict0rC

Vict0rC commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

I tried to answer everything right away. Did I miss something?

@Vict0rC Vict0rC requested a review from necouchman June 18, 2026 07:28

@necouchman necouchman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but the two lines that I had previously called out, I'm not sure why they're being modified at all? The lines were spaced such that they lined up with surrounding lines, which is consistent with the style in the translation files. As far as I can tell, there's no reason at all to modify those lines?

Sorry, it probably seems like I'm being pedantic or nit-picky, but we do have established style guidelines for reasons, and it'd be great if those two lines could just be restored to how they were before, as they're not really changing.

@@ -43,7 +43,7 @@

"FIELD_HEADER_PASSWORD" : "Heslo:",
"FIELD_HEADER_PASSWORD_AGAIN" : "Heslo znovu:",
"FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Povolit zápis do existujícího záznamového souboru:",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the line is no longer being removed, but the spacing that aligns it with the line below has now been removed. It looks like that's the only change to this line - the translation appears identical, so there's no reason to change this line at all, correct?

@@ -153,7 +154,7 @@
"SECTION_HEADER_FILE_TRANSFERS" : "Přenos souborů",
"SECTION_HEADER_INPUT_METHOD" : "Metoda vstupu",

"SECTION_HEADER_MOUSE_MODE" : "Mód emulace myši",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment above - the only change to this line appears to be removal of the space that aligns the spacing with the lines above it. There's no reason to change this, as far as I can tell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants