feat: add encode time tracking for shuffle operations#4068
Open
0lai0 wants to merge 3 commits intoapache:mainfrom
Open
feat: add encode time tracking for shuffle operations#40680lai0 wants to merge 3 commits intoapache:mainfrom
0lai0 wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1212
Part of #3996
Rationale for this change
Comet already reports encoding/compression metrics for native shuffle, but JVM columnar shuffle (CometColumnarExchange) either showed 0 ms or lacked a useful task-level distribution in SQL UI. This made it difficult to compare shuffle behavior across spark.comet.shuffle.mode=native and jvm, and reduced observability for JVM shuffle performance tuning.
What changes are included in this PR?
Aligned the JVM/native shuffle spill contract so encode/compression timing is propagated end-to-end: native spill results are consumed as (written_bytes, checksum, encode_nanos), with corresponding JNI/Java updates.
Added shared AtomicLong encode-time accumulators in
SpillWriter,CometShuffleExternalSorterSync/Async, andCometDiskBlockWriterso encode time is aggregated correctly across batches, spills, and concurrent sorter/writer instances.Added
getEncodeNanos()toCometShuffleExternalSorterand wired the accumulated value into theencode_time SQLMetricin bothCometUnsafeShuffleWriterandCometBypassMergeSortShuffleWriter.Ensured JVM columnar shuffle dependencies carry
shuffleWriteMetrics, allowingCometShuffleManagerto retrieve and pass encode_time into the shuffle writers.Added a regression test to verify encode_time exists and is greater than zero for columnar shuffle workloads.
How are these changes tested?