fix: resilient standard.site publishing (retry + non-fatal)#8
Merged
Conversation
A transient bsky.social response (e.g. 502 UpstreamFailure) failed the whole article-data build, aborting before deploy. Harden it two ways: - atproto.ts: retry transient conditions (network errors, 429, 5xx) with exponential backoff (4 attempts) in a shared fetchWithRetry, used by both xrpc and uploadBlob. - build.ts: catch and log a publish failure instead of throwing, so this secondary side-effect never blocks the primary article-data build/deploy. Also documents the icon convention and resilience behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient
502 UpstreamFailurefrom bsky.social failed an entire article-data build (angular-schule/website-articles run for #55), aborting before the deploy step. This hardens the publisher so a flaky PDS response can't block the primary build.Changes
atproto.ts—fetchWithRetry: retries transient conditions (network errors,429,5xx) with exponential backoff (4 attempts). Used by bothxrpcanduploadBlob.build.ts— thepublishStandardSitecall is wrapped in try/catch: a publish failure is logged, not thrown, so the standard.site side-effect never fails the article-data build/deploy. Records catch up on the next successful build.STANDARD-SITE.md— documents the resilience behaviour and the icon convention (icon lives in the website repo'spublic/, referenced by URL).Verification
npm run typecheckclean.fetchWithRetry) → OK.