Skip to content

Use Jsonable.fromString() in ConnectionState for consistency #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragonmantank merged 2 commits into from
Feb 20, 2026
Merged

Use Jsonable.fromString() in ConnectionState for consistency #611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4111674
Initial plan
Copilot Feb 20, 2026
a3e3e2d
Use Jsonable.fromString() for ConnectionState consistency
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/main/java/com/vonage/client/video/ConnectionState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import com.vonage.client.Jsonable;

/**
* Represents the state of a connection in a Vonage Video session.
Expand All @@ -37,15 +38,16 @@ public enum ConnectionState {
*/
DISCONNECTED;

/**
* Convert a string to a ConnectionState enum.
*
* @param value The string to convert.
*
* @return The ConnectionState as an enum, or {@code null} if invalid.
*/
@JsonCreator
public static ConnectionState fromString(String state) {
if (state == null) return null;
try {
return ConnectionState.valueOf(state.toUpperCase());
}
catch (IllegalArgumentException ex) {
return null;
}
public static ConnectionState fromString(String value) {
return Jsonable.fromString(value, ConnectionState.class);
}

@JsonValue
Expand Down