Use Jsonable.fromString() in ConnectionState for consistency#611
Merged
dragonmantank merged 2 commits intodevx-10296-list-video-connectionsfrom Feb 20, 2026
Merged
Use Jsonable.fromString() in ConnectionState for consistency#611dragonmantank merged 2 commits intodevx-10296-list-video-connectionsfrom
dragonmantank merged 2 commits intodevx-10296-list-video-connectionsfrom
Conversation
3 tasks
Co-authored-by: dragonmantank <108948+dragonmantank@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update list connections response based on feedback
Use Jsonable.fromString() in ConnectionState for consistency
Feb 20, 2026
8e6ff65
into
devx-10296-list-video-connections
14 checks passed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devx-10296-list-video-connections #611 +/- ##
=======================================================================
+ Coverage 98.90% 98.93% +0.03%
Complexity 3622 3622
=======================================================================
Files 545 545
Lines 8007 8004 -3
Branches 443 443
=======================================================================
Hits 7919 7919
+ Misses 66 64 -2
+ Partials 22 21 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionState.fromString()used a custom implementation while other enums in the video package (BroadcastStatus,ArchiveStatus,VideoType) consistently useJsonable.fromString().Changes
valueOf(state.toUpperCase())logic withJsonable.fromString(value, ConnectionState.class)Jsonableimportstatetovalueto match conventionFunctionality is preserved - both implementations handle null, case conversion, and invalid values identically.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.