Repository navigation
馃悰(dev-instance) name the sample versions on every deploy - #4
Merged
Merged
Conversation
A deploy that stored the content of the sample document but stopped before naming its versions left a document that the next deploys skipped. The seed now always runs the import: the import stores the content only when yhub has none, and adds the names that are missing. Signed-off-by: yousefed <yousefdardiry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The sample document of the dev instance must have its 15 named versions after every deploy.
Problem
The deploy of #1 used the yhub image of the upstream base. That image stored the content of the sample document, but it could not name the versions. The seed then stopped. The next deploys found a document with content and skipped it, so the named versions stayed missing.
Changes
How to test
dev.import: named 15 new versions of 15on the first deploy.import: named 0 new versions of 15.