Repository navigation
馃悰(dev-instance) store the sample content only once - #5
Merged
Merged
Conversation
The import tested for an empty document with the last clock of yhub, but the last clock stays 0 after the row the import writes itself. So every deploy stored the content of the sample document again. The import now looks for stored updates instead. Signed-off-by: yousefed <yousefdardiry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Every deploy must keep the sample document as it is. The deploy must not store its content again.
Problem
The import tested for an empty document with
lastClock === '0'. But yhub returns'0'also after the clock-0 row that the import writes itself. So each deploy after the first one stored the content of the sample document again, in one more row. The log of the deploy of #4 showsimport: stored the historyfor a document that already had its content.Changes
How to test
dev.import: yhub already holds the contentandimport: named 0 new versions of 15.