Skip to content

feat: Edit FlexNode Titles via Double-Click #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camielvs merged 1 commit into from
Feb 26, 2026
Merged

feat: Edit FlexNode Titles via Double-Click #1837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 53 additions & 13 deletions src/components/shared/ReactFlow/FlowCanvas/FlexNode/FlexNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
contentFontSize = 10,
} = properties;

const [isInlineEditing, setIsInlineEditing] = useState(false);
const [isContextPanelFocus, setIsContextPanelFocus] = useState(false);
const [isInlineEditingContent, setIsInlineEditingContent] = useState(false);
const [isInlineEditingTitle, setIsInlineEditingTitle] = useState(false);

const {
setContent,
Expand Down Expand Up @@ -72,7 +73,20 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
}

if (!readOnly) {
setIsInlineEditing(true);
setIsInlineEditingTitle(false);
setIsInlineEditingContent(true);
}
};

const handleDoubleClickTitle = (e: MouseEvent<HTMLParagraphElement>) => {
e.stopPropagation();
if (locked) {
toggleLock();
return;
}
if (!readOnly) {
setIsInlineEditingContent(false);
setIsInlineEditingTitle(true);
}
};

Expand All @@ -90,6 +104,19 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
updateProperties({
content: newContent,
});
setIsInlineEditingContent(false);
};

const handleSaveTitle = (newTitle: string) => {
updateProperties({
title: newTitle,
});
setIsInlineEditingTitle(false);
};

const switchEditor = () => {
setIsInlineEditingTitle((prev) => !prev);
setIsInlineEditingContent((prev) => !prev);
};

useEffect(() => {
Expand Down Expand Up @@ -177,22 +204,35 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
className="absolute top-1 right-1"
/>

{title && (
<p
style={{ fontSize: titleFontSize }}
className="font-bold whitespace-pre-wrap"
>
{title}
</p>
)}

{isInlineEditing ? (
{title &&
(isInlineEditingTitle ? (
<InlineTextEditor
value={title}
placeholder="Enter title..."
textSize={titleFontSize}
onSave={handleSaveTitle}
onCancel={() => setIsInlineEditingTitle(false)}
onTab={switchEditor}
className="font-bold"
/>
) : (
<p
style={{ fontSize: titleFontSize }}
className="font-bold whitespace-pre-wrap w-full"
onDoubleClick={handleDoubleClickTitle}
>
{title}
</p>
))}

{isInlineEditingContent ? (
<InlineTextEditor
value={content}
placeholder="Enter text..."
textSize={contentFontSize}
onSave={handleSaveContent}
onCancel={() => setIsInlineEditing(false)}
onCancel={() => setIsInlineEditingContent(false)}
onTab={switchEditor}
/>
) : (
<p
Expand Down
20 changes: 18 additions & 2 deletions src/components/shared/ReactFlow/FlowCanvas/FlexNode/InlineTextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,26 @@ import {
} from "react";

import { Textarea } from "@/components/ui/textarea";
import { cn } from "@/lib/utils";

interface InlineTextEditorProps {
value: string;
placeholder?: string;
textSize?: number;
className?: string;
onSave: (value: string) => void;
onCancel: () => void;
onTab?: () => void;
}

export const InlineTextEditor = ({
value,
placeholder = "Enter text...",
textSize,
className,
onSave,
onCancel,
onTab,
}: InlineTextEditorProps) => {
const [text, setText] = useState(value);
const textareaRef = useRef<HTMLTextAreaElement>(null);
Expand Down Expand Up @@ -55,6 +60,11 @@ export const InlineTextEditor = ({
e.preventDefault();
e.stopPropagation();
onSave(text);
} else if (e.key === "Tab") {
e.preventDefault();
e.stopPropagation();
onSave(text);
onTab?.();
}
};

Expand All @@ -66,8 +76,14 @@ export const InlineTextEditor = ({
onChange={handleChange}
onBlur={handleBlur}
onKeyDown={handleKeyDown}
className="min-h-10 resize-none nodrag nopan focus-visible:ring-0 focus-visible:border-0 focus-visible:text-xs text-xs shadow-none p-0 rounded-none"
style={{ fontSize: textSize }}
className={cn(
"min-h-10 resize-none nodrag nopan ring-0! border-0! text-xs shadow-none p-0 rounded-none",
className,
)}
style={{
fontSize: textSize,
minHeight: textSize ? textSize * 1.5 : undefined,
}}
onMouseDown={(e) => e.stopPropagation()}
onClick={(e) => e.stopPropagation()}
/>
Expand Down