Skip to content

feat: Edit FlexNode Titles via Double-Click#1837

Merged
camielvs merged 1 commit intomasterfrom
02-20-feat_edit_flexnode_titles_via_double-click
Feb 26, 2026
Merged

feat: Edit FlexNode Titles via Double-Click#1837
camielvs merged 1 commit intomasterfrom
02-20-feat_edit_flexnode_titles_via_double-click

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 21, 2026

Description

Similar to the flex node body content, the title (if present) can be edited directly on the node by double-clicking it.

Related Issue and Pull requests

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  • Add a Sticky Note with a title. Double click the title and confirm you can edit in-place
  • Remove the title. Double-click again and confirm that you are now editing the body

Additional Comments

@camielvs camielvs marked this pull request as ready for review February 21, 2026 00:43
@camielvs camielvs requested a review from a team as a code owner February 21, 2026 00:43
Copy link
Collaborator

I see some artfiacts during "double click" - "edit" - "blur" cycles. Also try to use tab key to navigate.

Screen Recording 2026-02-25 at 3.48.48 PM.mov (uploaded via Graphite)

Copy link
Collaborator

Another set of artifacts:

  1. Can use double click to "unlock" in curtain conditions.
  2. Height flickering
  3. Doing a cycle of "double-click" - "edit" - "blur" may lead to unwanted state

Screen Recording 2026-02-25 at 3.51.07 PM.mov (uploaded via Graphite)

Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say found "flickering" is minor - nice-to-fix, but unlikely to be encountered, and no harm.

@camielvs camielvs force-pushed the 02-20-chore_add_flexnode_update_hook branch from 588bb75 to 20a51c7 Compare February 26, 2026 04:04
@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch from 188bdd9 to 4ea2d21 Compare February 26, 2026 04:04
Copy link
Collaborator Author

camielvs commented Feb 26, 2026

^ I've updated and hopefully most of these issues should be resolved.

Double-click to unlock has been removed.

And I also added the ability to tab between editing title and content

@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch from 4ea2d21 to 640f803 Compare February 26, 2026 04:21
@camielvs camielvs force-pushed the 02-20-chore_add_flexnode_update_hook branch from 20a51c7 to 3ce0586 Compare February 26, 2026 04:23
@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch from 640f803 to 7c051a5 Compare February 26, 2026 04:23
@camielvs camielvs force-pushed the 02-20-chore_add_flexnode_update_hook branch from 3ce0586 to f40b05f Compare February 26, 2026 04:24
@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch from 7c051a5 to 13826a9 Compare February 26, 2026 04:24
@camielvs camielvs force-pushed the 02-20-chore_add_flexnode_update_hook branch from f40b05f to 585706d Compare February 26, 2026 04:30
@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch 2 times, most recently from 12373ad to 80aba95 Compare February 26, 2026 04:33
@camielvs camielvs force-pushed the 02-20-chore_add_flexnode_update_hook branch from 585706d to 11c0ed5 Compare February 26, 2026 04:33
Copy link
Collaborator Author

camielvs commented Feb 26, 2026

Merge activity

  • Feb 26, 4:37 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 4:42 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 26, 4:43 AM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs changed the base branch from 02-20-chore_add_flexnode_update_hook to graphite-base/1837 February 26, 2026 04:38
@camielvs camielvs changed the base branch from graphite-base/1837 to master February 26, 2026 04:40
@camielvs camielvs force-pushed the 02-20-feat_edit_flexnode_titles_via_double-click branch from 80aba95 to b1b30a2 Compare February 26, 2026 04:41
@camielvs camielvs merged commit d82b76f into master Feb 26, 2026
14 checks passed
@camielvs camielvs deleted the 02-20-feat_edit_flexnode_titles_via_double-click branch February 26, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants