Repository navigation
Fix KWin payload permissions after verified upgrades - #309
Merged
Merged
Conversation
Staphylococcus
marked this pull request as ready for review
October 6, 2026 15:59
This was referenced Oct 6, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A normal 1.9.0 → 1.10.0 update leaves the installed KWin source directory root-owned with mode 700 and its files with mode 600. The desktop user's native inspector then fails to open
source/CMakeLists.txtwithEACCES, producing the Plasma setup error in #300.Normalize directory and file permissions after copying the KWin payload into the system installation, retaining mode 755 for the two launchers. The updater's private staging permissions remain unchanged. Extend the existing cross-version smoke to stage the complete KWin tree privately and check installed permissions directly.
Scope
CONTRIBUTING.mdand the relevant docs linked there.User-Visible Behavior
Upgrading through a verified release bundle keeps the installed KWin payload readable by the desktop user, so Plasma status inspection succeeds without a manual reinstall. Saved configuration, pairing and KWin configuration are preserved.
Validation
install.sh --upgradewith public 1.10.0 binaries and the released updater's private staging modes. Both the compatibility helper and nativekwin-setup --statusreturned 0. All installed KWin directories/files had the expected permissions and root ownership; staging remained private, saved configuration/credentials were unchanged, and the published assessment had no Plasma failure.scripts/test-installer-first-run.shandscripts/test-installer-graphical-auth.shpassed.bash -n install.sh scripts/test-cross-version-upgrade.shandgit diff --checkpassed.Full CI is pending; this PR is a draft until the suite passes. The Plasma verification exercises the installer handoff with published binaries, not a newly published release. The separate service-hook assessment mismatch remains outside this fix.
Related Issue
Fixes #300