Repository navigation
zwave lock: migrate codeName to credentialName by default - #3346
Merged
Merged
Conversation
hcarter-775
requested review from
NoahCornell,
cbaumler,
ctowns and
tpmanley
November 12, 2026 18:38
|
Channel deleted. |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 257429e |
Test Results 73 files 571 suites 0s ⏱️ Results for commit 257429e. ♻️ This comment has been updated with latest results. |
ctowns
approved these changes
Nov 13, 2026
hcarter-775
force-pushed
the
zwave-lock/migrate-credential-name
branch
from
November 13, 2026 19:23
c7b5a30 to
257429e
Compare
hcarter-775
added a commit
that referenced
this pull request
Nov 13, 2026
This reverts commit 91a7498. Conflicts with later changes (#3337, #3339, #3346) in the zwave-lock tests were resolved by dropping the tests added by #3323 and keeping the lock_utils require and Schlage mock device that remaining code and tests still use. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Migrate the name value to the credentialName parameter of the lockCredentials table. It is already stored in the userName parameter of the lockUsers table. Technically, the credentialName value can store more data (up to 255 characters) than the userName table (up to 64), so in certain cases, migrating this way may save overly long data in a semi-recoverable way.
Summary of Completed Tests
Tests updated.