Repository navigation
Revert "Z-Wave Lock: Restore Migration on Device Added (#3323)" - #3351
Merged
Merged
Conversation
This reverts commit 91a7498. Conflicts with later changes (#3337, #3339, #3346) in the zwave-lock tests were resolved by dropping the tests added by #3323 and keeping the lock_utils require and Schlage mock device that remaining code and tests still use. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Channel deleted. |
Test Results 73 files 570 suites 0s ⏱️ Results for commit 201fee6. |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 201fee6 |
ctowns
approved these changes
Nov 13, 2026
ctowns
reviewed
Nov 13, 2026
| device:emit_event(capabilities.tamperAlert.tamper.clear()) | ||
| end | ||
| -- set initial state | ||
| driver:inject_capability_command(device, { |
Contributor
There was a problem hiding this comment.
should we still include the refresh in added even though we aren't migrating anymore? Won't this inject the sync?
Contributor
Author
There was a problem hiding this comment.
Yes, leaving that is fine because an un-migrated device will inject the legacy refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 91a7498.
Conflicts with later changes (#3337, #3339, #3346) in the zwave-lock tests were resolved by dropping the tests added by #3323 and keeping the lock_utils require and Schlage mock device that remaining code and tests still use.