Repository navigation
Z-Wave Lock: Restore Migration on Device Added - #3323
Merged
Merged
Conversation
This reverts commit b6e09b3. Only conflicts were in test_schlage_lock.lua, which have been resolved.
|
Channel deleted. |
|
zwave-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 57a2ca6 |
Test Results 73 files 548 suites 0s ⏱️ Results for commit 57a2ca6. |
hcarter-775
approved these changes
Nov 3, 2026
ctowns
added a commit
that referenced
this pull request
Nov 4, 2026
This reverts commit b6e09b3. Only conflicts were in test_schlage_lock.lua, which have been resolved.
hcarter-775
added a commit
that referenced
this pull request
Nov 13, 2026
This reverts commit 91a7498. Conflicts with later changes (#3337, #3339, #3346) in the zwave-lock tests were resolved by dropping the tests added by #3323 and keeping the lock_utils require and Schlage mock device that remaining code and tests still use. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
added a commit
that referenced
this pull request
Nov 13, 2026
…add-migration Revert "Z-Wave Lock: Restore Migration on Device Added (#3323)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b6e09b3. Only conflicts were in test_schlage_lock.lua, which have been resolved.
Check all that apply
Type of Change
Checklist
Description of Change
This is a restoration of the same auto-migration functionality that used to be included in this driver, but was removed to address issues and coordinate with partners. It is now being added back in anticipation of the forced migration to sunset SLGA.
Auto migration on add is already included in Zigbee and Matter lock drivers, so this will bring Z-Wave up to parity.
Summary of Completed Tests
Tested on a Yale lock, and includes unit tests.
Further testing will be done in beta alongside some of the master/admin code changes we are working on.