Skip to content

Remove less useful menu #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleboucher merged 1 commit into from
Aug 8, 2026
+65 −59
Merged

Remove less useful menu #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 65 additions & 59 deletions src/app/pages/client/SidebarNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,65 +39,71 @@ export function SidebarNav() {
return (
<>
<Sidebar onContextMenu={handleSidebarContextMenu}>
<ResponsiveMenu
anchor={sidebarMenu.anchor}
position="Right"
align="Start"
requestClose={sidebarMenu.close}
menu={
<Menu style={{ maxWidth: toRem(208), width: '100vw' }}>
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
size="300"
radii="300"
aria-pressed={showUnreadCounts}
onClick={() => setShowUnreadCounts(!showUnreadCounts)}
after={<Checkbox size="100" checked={showUnreadCounts} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show Room Counts
</Text>
</MenuItem>
<MenuItem
size="300"
radii="300"
aria-pressed={badgeCountDMsOnly}
onClick={() => setBadgeCountDMsOnly(!badgeCountDMsOnly)}
after={<Checkbox size="100" checked={badgeCountDMsOnly} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show DM Counts
</Text>
</MenuItem>
<MenuItem
size="300"
radii="300"
aria-pressed={showPingCounts}
onClick={() => setShowPingCounts(!showPingCounts)}
after={<Checkbox size="100" checked={showPingCounts} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show Mention Counts
</Text>
</MenuItem>
</Box>
<Line variant="Surface" size="300" />
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
size="300"
radii="300"
aria-pressed={uniformIcons}
onClick={() => setUniformIcons(!uniformIcons)}
after={<Checkbox size="100" checked={uniformIcons} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Consistent Icon Style
</Text>
</MenuItem>
</Box>
</Menu>
}
/>
{!compact && (
<ResponsiveMenu
anchor={sidebarMenu.anchor}
position="Right"
align="Start"
requestClose={sidebarMenu.close}
menu={
<Menu style={{ maxWidth: toRem(208), width: '100vw' }}>
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
size="300"
radii="300"
aria-pressed={showUnreadCounts}
onClick={() => setShowUnreadCounts(!showUnreadCounts)}
after={
<Checkbox size="100" checked={showUnreadCounts} readOnly tabIndex={-1} />
}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show Room Counts
</Text>
</MenuItem>
<MenuItem
size="300"
radii="300"
aria-pressed={badgeCountDMsOnly}
onClick={() => setBadgeCountDMsOnly(!badgeCountDMsOnly)}
after={
<Checkbox size="100" checked={badgeCountDMsOnly} readOnly tabIndex={-1} />
}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show DM Counts
</Text>
</MenuItem>
<MenuItem
size="300"
radii="300"
aria-pressed={showPingCounts}
onClick={() => setShowPingCounts(!showPingCounts)}
after={<Checkbox size="100" checked={showPingCounts} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Show Mention Counts
</Text>
</MenuItem>
</Box>
<Line variant="Surface" size="300" />
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
size="300"
radii="300"
aria-pressed={uniformIcons}
onClick={() => setUniformIcons(!uniformIcons)}
after={<Checkbox size="100" checked={uniformIcons} readOnly tabIndex={-1} />}
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Consistent Icon Style
</Text>
</MenuItem>
</Box>
</Menu>
}
/>
)}
<SidebarContent
scrollable={
<Scroll ref={scrollRef} variant="Background" size="0">
Expand Down
Loading