Add instanceFormat/certificateFormat declarations to TOPOLOGICALSORT - #497
Open
Trosper3 wants to merge 3 commits into
Open
Add instanceFormat/certificateFormat declarations to TOPOLOGICALSORT#497Trosper3 wants to merge 3 commits into
Trosper3 wants to merge 3 commits into
Conversation
TOPOLOGICALSORT never adopted the self-describing instance/ certificate format pattern (Interfaces/ProblemInterface.cs). Declares instanceFormat describing the (N,E) grammar and certificateFormat describing the linear-ordering certificate. Format-declaration tests follow the existing DFA/NFA_Tests pattern, plus a check that the certificate example quoted in the format string actually verifies true against defaultInstance.
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
2 tasks
…UE pattern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to TopologicalSortVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
wrigjl
pushed a commit
to wrigjl/Redux
that referenced
this pull request
Sep 2, 2026
…nges ProblemInstanceGenerators_Tests.cs and ProblemProvider_Endpoint_Tests.cs were merged with Allman-style braces, violating the repo's csharp_new_line_before_open_brace=none rule. This trips the EnforceFormatting build gate on every PR whose CI checks out the merge of PR-head + CSharpAPI, breaking PRs that never touched these files (e.g. ReduxISU#484, ReduxISU#488-490, ReduxISU#495, ReduxISU#497, ReduxISU#500).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interfaces/ProblemInterface.cs).instanceFormatdescribing the(N,E)grammar andcertificateFormatdescribing the linear-ordering certificate, onTOPOLOGICALSORT_Class.cs.{1,2,3,4,5,6}) actually verifies true againstdefaultInstancevia the real verifier.Closes #452
Test plan
dotnet test redux-tests/redux-tests.csproj --filter "FullyQualifiedName~TOPOLOGICALSORT"— 24/24 passing