Fix dotnet format violations blocking CI on unrelated PRs - #501
Merged
Conversation
…nges ProblemInstanceGenerators_Tests.cs and ProblemProvider_Endpoint_Tests.cs were merged with Allman-style braces, violating the repo's csharp_new_line_before_open_brace=none rule. This trips the EnforceFormatting build gate on every PR whose CI checks out the merge of PR-head + CSharpAPI, breaking PRs that never touched these files (e.g. #484, #488-490, #495, #497, #500).
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
wrigjl
approved these changes
Aug 23, 2026
wrigjl
left a comment
wrigjl
left a comment
Collaborator
There was a problem hiding this comment.
I knew we should have merged that huge diff sooner...
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
Extracts each constructor's inline StringParser grammar into a named InstanceGrammar const (single source of truth for both parsing and instanceFormat), and adds CertificateGrammar/CertificateExample consts to DFAVerifier/NFAVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. NFA keeps its epsilon-transition note as a separate clause outside the parsed grammar literal, since altering that literal would break parsing. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
Adds a named InstanceGrammar const (SPSP tries several StringParser grammar variants at parse time, so this is a display-only summary of the accepted shapes) and CertificateGrammar/CertificateExample consts on SPSPVerifier, interpolated into instanceFormat/certificateFormat instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
Adds a named InstanceGrammar const (SSSP tries several StringParser grammar variants at parse time, so this is a display-only summary of the accepted shapes) and CertificateGrammar/CertificateExample consts on SSSPVerifier, interpolated into instanceFormat/certificateFormat instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…ttern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to BinPackingVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…CLIQUE pattern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to DirectedHamiltonianVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…CLIQUE pattern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to MinimumSpanningTreeVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to NodeSetVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…tern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to PartitionVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…o match CLIQUE pattern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to SCCVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
Trosper3
added a commit
that referenced
this pull request
Aug 23, 2026
…UE pattern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to TopologicalSortVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose. Also merges in CSharpAPI (including #501) to pick up the dotnet-format gate this branch predates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSharpAPI's own tip currently failsdotnet format Redux.slnx --verify-no-changes(theEnforceFormattinggate inDirectory.Build.targets), because two test files merged in Add unit tests for ProblemInstanceGenerators #415/Add unit tests for ProblemProvider controller error paths and problemInstance #417 use Allman-style braces instead of the repo'scsharp_new_line_before_open_brace = noneconvention.CSharpAPI, every open PR inherits these 30 pre-existing violations regardless of what the PR itself touches. This is why Add instanceFormat/certificateFormat declarations to INTPROGRAMMING01 #484, Add instanceFormat/certificateFormat declarations to MINIMUMSPANNINGTREE #488, Add instanceFormat/certificateFormat declarations to NODESET #489, Add instanceFormat/certificateFormat declarations to PARTITION #490, Add instanceFormat/certificateFormat declarations to STRONGLYCONNECTEDCOMPONENTS #495, Add instanceFormat/certificateFormat declarations to TOPOLOGICALSORT #497, and Add instanceFormat/certificateFormat declarations to WEIGHTEDCUT #500 show a failingbuildjob even though their own diffs are unrelated.dotnet format Redux.slnxapplied to just these two files — brace-collapsing only, no logic changes.Test plan
dotnet build Redux.slnx --configuration Releasesucceeds (0 errors)dotnet test Redux.slnx --no-build --configuration Release— 838/838 passing