Skip to content

Add instanceFormat/certificateFormat declarations to MINIMUMSPANNINGTREE - #488

Open
Trosper3 wants to merge 3 commits into
CSharpAPIfrom
backfill/minimumspanningtree-format
Open

Add instanceFormat/certificateFormat declarations to MINIMUMSPANNINGTREE#488
Trosper3 wants to merge 3 commits into
CSharpAPIfrom
backfill/minimumspanningtree-format

Conversation

@Trosper3

Copy link
Copy Markdown
Contributor

Summary

  • MINIMUMSPANNINGTREE never adopted the self-describing instance/certificate format pattern (Interfaces/ProblemInterface.cs).
  • Declares instanceFormat describing the (N,E) weighted-graph grammar and certificateFormat describing the spanning-tree edge-set certificate, on MINIMUMSPANNINGTREE_Class.cs.
  • Format-declaration tests follow the existing DFA/NFA_Tests pattern, plus a check that the certificate example quoted in the format string ({{1,2},{3,4},{2,3}}) actually verifies true against defaultInstance via the real verifier.

Closes #443

Test plan

  • dotnet test redux-tests/redux-tests.csproj --filter "FullyQualifiedName~MINIMUMSPANNINGTREE" — 24/24 passing

MINIMUMSPANNINGTREE never adopted the self-describing instance/
certificate format pattern (Interfaces/ProblemInterface.cs). Declares
instanceFormat describing the (N,E) weighted-graph grammar and
certificateFormat describing the spanning-tree edge-set certificate.

Format-declaration tests follow the existing DFA/NFA_Tests pattern,
plus a check that the certificate example quoted in the format string
actually verifies true against defaultInstance.
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

Redux Build System — CI Report

dotnet · commit b1a8155

Operation Status Summary Time
audit no known vulnerabilities 3.9s
format-check all files formatted 22.3s
lint 0 issues 34.9s
typecheck ⏭️ covered by lint (dotnet build)
unit-test 841 passed · coverage 65% (min 80%) 43.1s
build built local/redux:ci · 234MB 38.1s
integration-test ⏭️ no [integration] command
push ⏭️ not implemented

Overall: ❌ 4 passed · 1 failed · 3 skipped

…CLIQUE pattern

Extracts the constructor's inline StringParser grammar into a named
InstanceGrammar const, and adds CertificateGrammar/CertificateExample
consts to MinimumSpanningTreeVerifier. instanceFormat/certificateFormat
are now interpolated from these plus _defaultInstance, instead of
hand-duplicated prose.

Also merges in CSharpAPI (including #501) to pick up the dotnet-format
gate this branch predates.
@Trosper3
Trosper3 requested a review from wrigjl August 31, 2026 18:04
wrigjl pushed a commit to wrigjl/Redux that referenced this pull request Sep 2, 2026
…nges

ProblemInstanceGenerators_Tests.cs and ProblemProvider_Endpoint_Tests.cs
were merged with Allman-style braces, violating the repo's
csharp_new_line_before_open_brace=none rule. This trips the
EnforceFormatting build gate on every PR whose CI checks out the
merge of PR-head + CSharpAPI, breaking PRs that never touched these
files (e.g. ReduxISU#484, ReduxISU#488-490, ReduxISU#495, ReduxISU#497, ReduxISU#500).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill instanceFormat/certificateFormat: NPC_MINIMUMSPANNINGTREE

1 participant