Skip to content

Items tab: sorting crafted item modifiers alphabetically #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Taigore wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Items tab: sorting crafted item modifiers alphabetically #1629

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8938c2c
Changes crafted modifiers sort order
Jul 6, 2019
4791311
Fixes whitespace
Jul 6, 2019
0738c38
Interim merge of updates
Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Classes/ItemsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,6 +1568,23 @@ function ItemsTabClass:AddCustomModifierToDisplayItem()
})
end
end

-- Sorts modifiers by label
-- Ignores the initial magnitude part
-- Ex: "+10% ham" comes after "Gummybears"
table.sort(modList, function comparator(l, r)
local l_first_letter_index = string.find(l.label, "[%u%l]")
local r_first_letter_index = string.find(r.label, "[%u%l]")

local lthunk = string.lower(string.sub(l.label, l_first_letter_index))
local rthunk = string.lower(string.sub(r.label, r_first_letter_index))

if lthunk < rthunk then
return true
else
return false
end
end)
elseif sourceId == "ESSENCE" then
for _, essence in pairs(self.build.data.essences) do
local modId = essence.mods[self.displayItem.type]
Expand Down