Items tab: sorting crafted item modifiers alphabetically#1629
Open
Taigore wants to merge 3 commits intoOpenarl:devfrom
Taigore:dev
Open
Items tab: sorting crafted item modifiers alphabetically#1629Taigore wants to merge 3 commits intoOpenarl:devfrom Taigore:dev
Taigore wants to merge 3 commits intoOpenarl:devfrom
Taigore:dev
Conversation
added 2 commits
July 6, 2019 15:56
Crafted item modifiers where not sorted according to any specific criteria. Now they are sorted in alphabetical order, excluding any initial magnitude prefix: Ex: "+10% ham" comes after "Gummybears"
|
All the +(x) to ... will all be sorted with "to". Can you do like "+10 to maximum life" is sorted with "maximum life". Also if the "Adds x to y TYPE damage" can be sorted with "TYPE damage". All this will allow the have all "lightning" modifier (resistance, flat damage, dmg increase, ...) following each other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I created this patch to sort crafted modifiers by name. The sorting function ignores the inital magnitude part (ex: +10%)
Let me know if anything needs to be done differently.