fix(cudacompat): TestGlobFiles/multiple_matches determinism#1846
Closed
damaestro wants to merge 1 commit into
Closed
fix(cudacompat): TestGlobFiles/multiple_matches determinism#1846damaestro wants to merge 1 commit into
damaestro wants to merge 1 commit into
Conversation
cdesiniotis
reviewed
May 26, 2026
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
Thanks for the contribution @damaestro. Can you make the same change to container-root_other.go as well?
Contributor
|
Also, please sign-off your commit. |
cdesiniotis
force-pushed
the
damestro/fix-cudacompat-multiple_matches-determinism
branch
from
7252aa3 to
5f0f3ff
Compare
Co-authored by: Jonathan Steffan <jsteffan@fedoraproject.org> Signed-off by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
damestro/fix-cudacompat-multiple_matches-determinism
branch
from
5f0f3ff to
110540a
Compare
Contributor
|
Closing in favor of #1856. @damaestro I added you as a co-author there. |
Contributor
Author
|
Sorry, I was away on holiday. Thanks for getting this fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had this test pass and had it fail when building for the Fedora copr. This should fix it up.