fix failing test in TestGlobFiles#1855
Closed
tariq1890 wants to merge 1 commit into
Closed
Conversation
This commit addresses a unit test failure observed in the "multiple matches" scenario where the expected and actual arrays match but don't have the same order. We fix this by only requiring that the elements in the slice match regardless of the order. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Coverage Report for CI Build 26544578702Warning No base build found for commit Coverage: 43.492%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Closing in favour of #1846 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a unit test failure observed in the "multiple matches" scenario where the expected and actual arrays match but don't have the same order. We fix this by only requiring that the elements in the slice match regardless of the order.