Skip to content

Add case default #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adammaycock merged 2 commits into from
Feb 4, 2026
Merged

Add case default #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a5996
Add case default
DJDavies2 Feb 2, 2026
9c24519
Add warning messages
DJDavies2 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/opsinputs/opsinputs_cxwriter_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,8 @@ subroutine opsinputs_cxwriter_addrequiredgeovars(self, geovars)
character(len=max_varname_length) :: GeoVarName
integer :: DustBinIndex
character :: DustBinIndexStr
character(len=80) :: ErrorMessage
character(len=*), parameter :: RoutineName = "opsinputs_cxwriter_addrequiredgeovars"

! Body:
call Ops_ReadCXControlNL(self % obsgroup, CxFields, BGECall = .false._8, ops_call = .false._8)
Expand Down Expand Up @@ -773,6 +775,10 @@ subroutine opsinputs_cxwriter_addrequiredgeovars(self, geovars)
write (DustBinIndexStr, '(i1)') DustBinIndex
GeoVarName = opsinputs_cxfields_dustp_start // DustBinIndexStr // opsinputs_cxfields_dustp_end
end if
case default
write (ErrorMessage, '("Stash code not recognized: ",I0)') CxField
call gen_warn(RoutineName, ErrorMessage)
continue

end select

Expand Down Expand Up @@ -1271,6 +1277,10 @@ subroutine opsinputs_cxwriter_populatecx(self, ReportFlags, Cx)
opsinputs_cxfields_dustp_start // DustBinIndexStr // opsinputs_cxfields_dustp_end, &
self % JediToOpsLayoutMapping, self % hofx, self % varnames)
end if
case default
write (ErrorMessage, '("Stash code not recognized: ",I0)') CxField
call gen_warn(RoutineName, ErrorMessage)
continue
end select
end do
end subroutine opsinputs_cxwriter_populatecx
Expand Down
6 changes: 6 additions & 0 deletions src/opsinputs/opsinputs_varobswriter_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,8 @@ subroutine opsinputs_varobswriter_addrequiredgeovars(self, geovars)
! Local declarations:
integer(integer64) :: VarFields(ActualMaxVarfield)
integer :: i
character(len=80) :: ErrorMessage
character(len=*), parameter :: RoutineName = "opsinputs_varobswriter_addrequiredgeovars"

! Body:
call Ops_ReadVarobsControlNL(self % obsgroup, VarFields)
Expand All @@ -616,6 +618,10 @@ subroutine opsinputs_varobswriter_addrequiredgeovars(self, geovars)
! TODO(someone): "land_type_index" may not be the right geoval to use. If it isn't, change it
! here and in opsinputs_varobswriter_populateobservations.
call geovars % push_back("land_type_index")
case default
write (ErrorMessage, '("Varfield not recognized: ",I0)') VarFields(i)
call gen_warn(RoutineName, ErrorMessage)
continue
end select
end do

Expand Down