Merged
Conversation
DJDavies2
requested review from
adammaycock,
ctgh,
matthewrmshin,
mikecooke77 and
yaswant
as code owners
Collaborator
Author
matthewrmshin
approved these changes
Feb 3, 2026
stemiglio
reviewed
Feb 3, 2026
Contributor
stemiglio
left a comment
stemiglio
left a comment
There was a problem hiding this comment.
I see your point on the probable need of a fatal error when fields are not found. But as you say this may produce changes in the tests. Perhaps we could at least ad a warning? See my comment below.
stemiglio
approved these changes
Feb 3, 2026
Contributor
stemiglio
left a comment
stemiglio
left a comment
There was a problem hiding this comment.
Thanks for adding the warning messages!
matthewrmshin
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #273.
This fix is semantically equivalent to the code in develop. However it is probably not correct as looking at the relative select case blocks it looks like if the select falls through to the end and doesn't match anything it is probably an error and the code should abort. This would be a change of behaviour and it might fail tests. Let me know which you would prefer.