Add Mooncake rule for propagate e_mul_xj fast path and added tests#678
Merged
CarloLucibello merged 1 commit intoJul 3, 2026
Merged
Conversation
Contributor
Author
|
@CarloLucibello please review this after #677 |
Member
|
this seems fine, just needs rebase |
Parvm1102
force-pushed
the
perf/emul-xj-mooncake
branch
from
July 1, 2026 09:19
fff4d3a to
8b537e1
Compare
|
Mind also adding an enzyme rule too (in addition to those in the other PRs) |
Member
we will tackle this after mooncake is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the propagate
e_mul_xjfast path. This pr depends on #677 so that should be merged first.Benchmark Results
The rules matched for the following layers, the improvements and the benchmarks are listed below, all layers pass the gradient correctness benchmarks:
GCNConv
SGConv (k=2)
TAGConv (k=2)
I have also added an extra test for this change.