Add Mooncake extension for propagate copy_xj (+) fast path and enable tests#677
Merged
CarloLucibello merged 1 commit intoJul 1, 2026
Conversation
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
Contributor
Author
|
@CarloLucibello Could you please review this? |
Contributor
Author
|
The checks failing aren't related to this pr, the #678 which is a stacked pr on this passes all checks. |
Member
|
yes failing tests are unrelated and I will fix them in a maintainance PR |
|
Nice work on the rule, mind adding one for enzyme too? |
Contributor
Author
I will do it. We were planning that anyway. Though it might take some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNN AD Benchmark Results
The rules matched for the following layers, the improvements and the benchmarks are listed below, all layers pass the gradient correctness benchmarks:
GCNConv
GraphConv
SAGEConv (aggr=+)
GINConv
SGConv (k=2)
TAGConv (k=2)
GatedGraphConv (L=2)
The PR also enables Mooncake testing in the same way currently as done here:
https://github.com/JuliaGraphs/GraphNeuralNetworks.jl/blob/f09fcc4af170c1d87dc1d51648c3a015357fea93/GraphNeuralNetworks/test/test_module.jl
I will fix the format as mentioned in #676 in a future PR.