Repository navigation
Keep coverage working on Julia 1.14 - #94
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 96.06% 95.81% -0.26%
==========================================
Files 4 4
Lines 356 358 +2
==========================================
+ Hits 342 343 +1
- Misses 14 15 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JuliaLang/julia#63314 renamed PkgLoadSpec.julia_syntax_version to julia_edition and changed its type to a (major, minor) tuple. Convert that tuple to the VersionNumber expected by JuliaSyntax while continuing to use the old field on earlier 1.14 nightlies.
JuliaLang/julia#62514 instruments interpreted top-level statements and JuliaLang/julia#62724 defaults to hit counts. Update the fixture expectations and derive the folder summary from the per-file expectation, keeping exact count checks on every Julia version.
maleadt
force-pushed
the
hr/fix_nightly_ci
branch
from
October 2, 2026 10:32
69811f8 to
f8c2340
Compare
maleadt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.14 now instruments interpreted top-level statements and reports whether a line ran by default. In our source fixture, statements such as
if trueand module declarations now have coverage; the fixture has eight covered lines instead of one on Julia 1.13. Update the 1.14 expectations while retaining exact line-count checks on every supported version.A newer Julia 1.14 change renamed
Base.PkgLoadSpec.julia_syntax_versiontojulia_editionand represents the edition as a(major, minor)pair. CoverageTools reads this value when parsing source to mark function-body lines that were never compiled. Without the update, processing package coverage fails with aFieldErrorbefore it can produce a report. Convert the new pair to theVersionNumberexpected by JuliaSyntax, while keeping the old path for earlier 1.14 nightlies.The test suite passes on Julia 1.10.12, 1.13.1, and 1.14.0-DEV.3469 on Linux, and 1.14.0-DEV.3475 on macOS. The macOS run exercises the renamed field.
Codecov's patch and project checks are red because the Linux nightly used by CI is still DEV.3469, before the field rename, so it cannot cover the new branch. The macOS DEV.3475 run above verifies that branch. The minimum-coverage check was already red on the previous PR revision.