fix(analysis): resolve unresolved merge-conflict markers in __init__ (package failed to import) - #405
Conversation
…(package failed to import)
…nblocks CI) A botched merge left nested git conflict markers in trinity/analysis/__init__.py (union_diagnostics vs oracle_column vs definition_of_done import blocks), so the package is invalid Python and ruff/import fail on every branch. __all__ already lists the symbols of all three modules, so all three import blocks are intended; keep them. Stacked here only to green this PR's CI while the same repair lands via James-CUDA#402/James-CUDA#405 -- it drops out on rebase once main is fixed.
Three PRs are waiting on this file#415, #416 and #417 are all red solely on these conflict markers — none of them touches Useful context for whoever merges: five PRs carry this exact fixThis resolution is not contested. #402, #405, #407, #408 and #403 all rewrite #407 / #408 / #403 are already green, because they each touch this file for their own feature and resolved it along the way. So there's nothing to arbitrate between the competing fixes — there is only one resolution in play. Merging any one of the five repairs |
… can validate this PR main currently fails Ruff/pytest by itself: src/trinity/analysis/__init__.py carries unresolved merge-conflict markers (James-CUDA#404), so every PR's merge-ref CI is red before it reaches the PR's own changes. This commit applies the only correct resolution — keep all three import blocks (union_diagnostics, oracle_column, definition_of_done), the same resolution James-CUDA#402/James-CUDA#405 propose — purely to unblock CI validation of the scoring fix in this branch. Once the dedicated fix lands on main this resolves to a no-op in the merge (or will be dropped by rebase); credit for the James-CUDA#404 fix belongs to those PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nblocks CI) A botched merge left nested git conflict markers in trinity/analysis/__init__.py (union_diagnostics vs oracle_column vs definition_of_done import blocks), so the package is invalid Python and ruff/import fail on every branch. __all__ already lists the symbols of all three modules, so all three import blocks are intended; keep them. Stacked here only to green this PR's CI while the same repair lands via #402/#405 -- it drops out on rebase once main is fixed.
…ate this PR main currently fails Ruff/pytest by itself: src/trinity/analysis/__init__.py carries unresolved merge-conflict markers (#404), so every PR's merge-ref CI is red before it reaches the PR's own changes. This commit applies the only correct resolution — keep all three import blocks (union_diagnostics, oracle_column, definition_of_done), the same resolution #402/#405 propose — purely to unblock CI validation of the scoring fix in this branch. Once the dedicated fix lands on main this resolves to a no-op in the merge (or will be dropped by rebase); credit for the #404 fix belongs to those PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fixes #404
What
src/trinity/analysis/__init__.pyonmaincontains unresolved git merge-conflict markers (<<<<<<< HEAD/=======/>>>>>>>, six of them). Python can't parse the file:so the entire
trinity.analysispackage fails to import, cascading into a large swath of the suite and red main CI.Root cause + fix
A three-way merge of recently-landed analysis PRs left a nested conflict in the import block —
union_diagnostics,oracle_column(results_table columns), anddefinition_of_done(SPEC roll-up) each added an import group. All three are legitimate; this resolves the markers keeping all three import blocks.Verification
import trinity.analysissucceeds;import *works. Full suite:1726 passed(the only failures are pre-existingreport_script/grader_auditsubprocess tests that needpip install -e, which CI does — they pass on CI).ruff+mypyclean on the changed file.