Skip to content

fix: resolve leftover merge-conflict markers breaking analysis/__init__.py (main does not import) - #402

Merged
James-CUDA merged 1 commit into
James-CUDA:mainfrom
philluiz2323:fix/analysis-init-merge-conflict-markers
Jul 23, 2026
Merged

fix: resolve leftover merge-conflict markers breaking analysis/__init__.py (main does not import)#402
James-CUDA merged 1 commit into
James-CUDA:mainfrom
philluiz2323:fix/analysis-init-merge-conflict-markers

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

Type

  • General improvement — bug fix, docs, refactor, or infrastructure (welcome but earns no TAO)

General improvement

What does this PR do?

main does not import. src/trinity/analysis/__init__.py carries unresolved merge-conflict markers — a botched 3-way merge of the oracle_column and definition_of_done additions — so import trinity.analysis raises:

SyntaxError: invalid character '§' (U+00A7)

and the entire test suite fails to collect (every test that imports trinity.analysis errors at import). This PR resolves the markers.

The three tangled import blocks are all legitimate, non-overlapping additions, so the resolution keeps all of them — union_diagnostics, oracle_column, and definition_of_done. Their names were already present in __all__ (that region had no markers), so no export changes were needed.

Why is it needed?

CI is red on main at collection time; nothing can be tested until the module imports. This restores the analysis package.

# before
$ python -c "import trinity.analysis"
SyntaxError: invalid character '§' (U+00A7)

# after
$ python -c "import trinity.analysis"   # OK

Checklist

  • Tests pass: pytest tests/import trinity.analysis now succeeds and the previously-uncollectable analysis tests run again (e.g. test_ablations.py, test_ensemble.py, test_per_question_best.py — 36 passed in the affected slice). Before this PR they errored at collection with the SyntaxError above.
  • Lint passes: ruff check src/ — clean on the changed file.
  • Type check passes: mypy src/ (for changed files).
  • New code follows existing style (only conflict markers removed; the surviving imports are the ones both PRs added).
  • Public functions have docstrings and type annotations (n/a — imports only).

main did not import: src/trinity/analysis/__init__.py carried unresolved
conflict markers (a botched 3-way merge of the oracle_column and
definition_of_done additions), so `import trinity.analysis` raised
SyntaxError: invalid character '§' and the ENTIRE test suite failed to collect.

The three tangled import blocks are all legitimate, non-overlapping additions,
so the resolution keeps all of them: union_diagnostics, oracle_column, and
definition_of_done. Their names were already present in __all__ (that region had
no markers), so no export changes were needed.

After this, `import trinity.analysis` succeeds and the previously-uncollectable
analysis tests run again.
galuis116 added a commit to galuis116/Gittensor-TinyRouter that referenced this pull request Jul 22, 2026
…nblocks CI)

A botched merge left nested git conflict markers in trinity/analysis/__init__.py
(union_diagnostics vs oracle_column vs definition_of_done import blocks), so the
package is invalid Python and ruff/import fail on every branch. __all__ already
lists the symbols of all three modules, so all three import blocks are intended;
keep them. Stacked here only to green this PR's CI while the same repair lands via
James-CUDA#402/James-CUDA#405 -- it drops out on rebase once main is fixed.
@minion1227

minion1227 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Three PRs are waiting on this file

#415, #416 and #417 are all red solely on these conflict markers — none of them touches src/trinity/analysis/__init__.py, so the merge base is their only failing check. #412 is in the same position.

Useful context for whoever merges: five PRs carry this exact fix

This resolution is not contested. #402, #405, #407, #408 and #403 all rewrite src/trinity/analysis/__init__.py to the byte-identical result — every one of them is index 9916618..6865bc2 — the union resolution that keeps all three import blocks (union_diagnostics, oracle_column, definition_of_done) and repairs the stray paren.

#407 / #408 / #403 are already green, because they each touch this file for their own feature and resolved it along the way.

So there's nothing to arbitrate between the competing fixes — there is only one resolution in play. Merging any one of the five repairs main and turns the rest into no-ops on this file. The dedicated fix PRs (#402/#405) are the lowest-risk route since they change nothing else, but a green feature PR that carries the same resolution works just as well.

RealDiligent added a commit to RealDiligent/Gittensor-TinyRouter that referenced this pull request Jul 22, 2026
… can validate this PR

main currently fails Ruff/pytest by itself: src/trinity/analysis/__init__.py
carries unresolved merge-conflict markers (James-CUDA#404), so every PR's merge-ref CI
is red before it reaches the PR's own changes. This commit applies the only
correct resolution — keep all three import blocks (union_diagnostics,
oracle_column, definition_of_done), the same resolution James-CUDA#402/James-CUDA#405 propose —
purely to unblock CI validation of the scoring fix in this branch. Once the
dedicated fix lands on main this resolves to a no-op in the merge (or will be
dropped by rebase); credit for the James-CUDA#404 fix belongs to those PRs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@James-CUDA
James-CUDA merged commit af8d932 into James-CUDA:main Jul 23, 2026
2 checks passed
James-CUDA pushed a commit that referenced this pull request Jul 23, 2026
…nblocks CI)

A botched merge left nested git conflict markers in trinity/analysis/__init__.py
(union_diagnostics vs oracle_column vs definition_of_done import blocks), so the
package is invalid Python and ruff/import fail on every branch. __all__ already
lists the symbols of all three modules, so all three import blocks are intended;
keep them. Stacked here only to green this PR's CI while the same repair lands via
#402/#405 -- it drops out on rebase once main is fixed.
James-CUDA pushed a commit that referenced this pull request Jul 23, 2026
…ate this PR

main currently fails Ruff/pytest by itself: src/trinity/analysis/__init__.py
carries unresolved merge-conflict markers (#404), so every PR's merge-ref CI
is red before it reaches the PR's own changes. This commit applies the only
correct resolution — keep all three import blocks (union_diagnostics,
oracle_column, definition_of_done), the same resolution #402/#405 propose —
purely to unblock CI validation of the scoring fix in this branch. Once the
dedicated fix lands on main this resolves to a no-op in the merge (or will be
dropped by rebase); credit for the #404 fix belongs to those PRs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants