Skip to content

fix(deploy): isolate production concurrency #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoland merged 1 commit into from
Jul 28, 2026
Merged

fix(deploy): isolate production concurrency #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/pages-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ permissions:
actions: read
contents: read

concurrency:
group: pages-main
cancel-in-progress: true

jobs:
identity:
name: Resolve trusted production identity
Expand Down Expand Up @@ -70,6 +66,9 @@ jobs:
deploy:
name: Deploy checked website artifact
needs: identity
concurrency:
group: pages-main
cancel-in-progress: true
permissions:
actions: read
contents: read
Expand Down
5 changes: 5 additions & 0 deletions tasks/vitepress-documentation-site/implementation-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,11 @@ GitHub preparation completed on 2026-07-28: the selected organization secrets no
deployments only from `main`. The workflow remains responsible for idempotently reconciling the
Cloudflare Pages project and custom domain.

The first production run exposed an ordering property of `workflow_run`: a Dependabot pull
request completion can start the delivery controller even when its identity job will be skipped.
Keep production concurrency on the deploy job, after trusted-main identity resolution, so an
ineligible controller run cannot cancel an active production deployment.

When the first published route moves, add its direct permanent redirect under
`website/content/public/_redirects` and verify both old and new URLs. Do not add custom global
cache rules until measured behavior requires them.
Expand Down