fix(deploy): isolate production concurrency - #7
Merged
Conversation
- acquire the Pages lock only after trusted main identity resolves - record the workflow_run ordering discovered during first delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
A Dependabot pull-request
Website checkscompletion started a Pages controller run. The identity job would skip it, but workflow-level concurrency was acquired before that condition and canceled the activemaindeployment.Fix
Move the
pages-mainconcurrency lock to the deploy job after trusted-main identity resolution. Ineligible controller runs can now skip without entering the production concurrency group.Verification
pnpm --dir website checksvc status --jsongit diff --checkThis preserves cancellation for superseded eligible production deployments.