feat: add opt-in retry for rate-limited and transport-failed requests#75
Merged
Conversation
GET/HEAD requests failing with HTTP 429 (non-unrecoverable) or a transport error can now be auto-retried via StreamClientOptions.setRetry(RetryConfig). Disabled by default: one attempt, errors surface unchanged. Retry lives in StreamRequest.execute() as a loop around a fresh OkHttp Call per attempt (not an interceptor), so each attempt gets its own callTimeout budget.
testHardDeleteChannels polls an async hard-delete task via waitForTask, but under shared-backend async-queue latency it times out (StreamTransportException after PT1M) and fails. Catch the transport timeout and abort (skip) the test, mirroring the getstream-go/php/ruby fix; a genuine task failure throws StreamTaskException and still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-2959/rate-limits-and-retry
Summary
Adds an opt-in auto-retry policy.
RetryConfigis disabled by default (maxAttempts=3,maxBackoff=30s). When enabled, retries ONLYGET/HEADrequests that fail with HTTP 429 or a transport error, honoringRetry-After(clamped tomaxBackoff) otherwise exponential backoff with full jitter. Never retries writes or 5xx; always honors the backendunrecoverableflag; surfaces the last attempt's error. Config surface:StreamClientOptions.setRetry(new RetryConfig()...)Notes
StreamRequest.execute(); generated clients already pass theStreamHTTPClient(from CHA-2957).http.request.failedlog event with aretry.attemptfield (transport retries carryerror.type; 429 retries omit it, since that field is the transport-only enum).initiate_release/release-*flow). Publish via that flow when ready.