[MISC] Propagate interactive viewer exceptions when running in thread.#2436
Closed
hughperkins wants to merge 1 commit intoGenesis-Embodied-AI:mainfrom
Closed
[MISC] Propagate interactive viewer exceptions when running in thread.#2436hughperkins wants to merge 1 commit intoGenesis-Embodied-AI:mainfrom
hughperkins wants to merge 1 commit intoGenesis-Embodied-AI:mainfrom
Conversation
duburcqa
reviewed
Feb 19, 2026
| except AttributeError: | ||
| # The graphical window has been closed manually | ||
| pass | ||
| except Exception as e: |
Collaborator
There was a problem hiding this comment.
Remove this. It is not applicable here.
duburcqa
reviewed
Feb 19, 2026
| self._viewer.update(auto_refresh=auto, force=force) | ||
| else: | ||
| gs.raise_exception("Viewer closed.") | ||
| pyrender_viewer = self._viewer._pyrender_viewer |
Collaborator
There was a problem hiding this comment.
This is not the right place to do this. I would suggest to “refactor” this part to move the responsibility of handling exception in viewer. This means not checking if viewer is alive anymore in this function.
duburcqa
changed the title
duburcqa
changed the title
|
🔴 Benchmark Regression Detected ➡️ Report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.