Skip to content

fix: missed notebook contents! #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 10 commits into from
Feb 18, 2026
Merged

fix: missed notebook contents! #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8087935
fix: do not support trunc or high maxk thresholds for Moffat profiles
beckermr Feb 12, 2026
1846f04
test: fix tests and exclude the jax galsim error
beckermr Feb 12, 2026
f4f8bef
perf: use an approximation for maxk for Moffat profiles
beckermr Feb 12, 2026
52b0017
perf: use 100 insteadof 500
beckermr Feb 12, 2026
976bbe6
style: pre the commit
beckermr Feb 12, 2026
efc4afb
doc: add dev notebook
beckermr Feb 12, 2026
a5254e5
fix: try simpler ways to build moffat splines
beckermr Feb 16, 2026
2979e22
feat: use a more efficient rational function approximation
beckermr Feb 18, 2026
d377c2e
doc: add comment pointing to dev notebook
beckermr Feb 18, 2026
65d910b
Merge branch 'main' into moffat-perf-maxk
beckermr Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 155 additions & 18 deletions dev/notebooks/moffat_maxk_interp.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions jax_galsim/moffat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,10 @@ def _shoot(self, photons, rng):
photons.flux = self.flux / photons.size()


# this fitting function and code to build it is defined in the
# dev notebook dev/notebooks/moffat_maxk_interp.ipynb
# !!! DO NOT CHANGE ANY OF THE VARIABLES BELOW !!!

# order of rational function in log(maxk_threshold), log(beta)
PADE_ORDERS = [9, 11]

Expand Down