Skip to content

fix: apply geometry transforms after orientation rotation - #1608

Open
TomasVSantos wants to merge 2 commits into
CyberTimon:mainfrom
TomasVSantos:tomas/fix-rotated-transform-axes
Open

fix: apply geometry transforms after orientation rotation#1608
TomasVSantos wants to merge 2 commits into
CyberTimon:mainfrom
TomasVSantos:tomas/fix-rotated-transform-axes

Conversation

@TomasVSantos

Copy link
Copy Markdown
Contributor

Description

Fixes #1603. Geometry transforms now respect the image’s current orientation, so Vertical and Horizontal adjustments consistently operate on the displayed image axes and move in the expected direction.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Code refactoring
  • Documentation update
  • UI/UX improvement
  • Build/CI or Dependency update

Changes Made

  • Apply image orientation and flips before geometry transforms.
  • Keep Vertical and Horizontal adjustments screen-relative across all image orientations.
  • Align the main render pipeline, transform preview, uncropped preview, and thumbnail generation.
  • Update inverse mask and point transformations to match the new processing order.

Screenshots/Videos

Not applicable.

Testing

  • These changes were tested locally by a human and confirmed to work.
  • I haven't added any automated tests to the code because the codebase currently lacks a test suite.

Test Configuration:

  • OS: macOS 26.3.1
  • Hardware: Apple Silicon (arm64)

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

Additional Notes

The repository’s TypeScript typecheck reports unrelated pre-existing errors in unchanged files.

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is created by an AI agent
  • This PR is mostly AI-generated but edited/merged together by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@TomasVSantos
TomasVSantos force-pushed the tomas/fix-rotated-transform-axes branch from 8c943c0 to 5d7b1cc Compare August 29, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: in a rotated photo (90°) transform Vert/Or works as the photo is not rotated

1 participant