SDK-6011: Regression tests for BOX/video/evaluator #54 parity - #79
Merged
CTLalit merged 1 commit intoAug 13, 2026
Merged
Conversation
Android/iOS #54 fixed BOX hit-testing, video-controls tap reliability, numeric-boolean evaluation, and non-string JSON binding values. The Flutter renderer already meets this parity (Stack fall-through hit-testing, HitTestBehavior.opaque video overlay with no stale timer, num!=0 + "1.0" coercion). This locks it in with regression tests — NO behaviour change, zero non-test source touched. - box_hit_test_test.dart: non-interactive sibling stacked over an interactive child does not swallow the tap; topmost interactive child wins (z-order). - video_controls_tap_test.dart: controls overlay uses HitTestBehavior.opaque, tap toggles play/pause (via a fake VideoPlayerPlatform), showControls:false renders no overlay. - business_logic_test.dart: numeric-boolean literals + raw-JSON variable values coerce to bool; non-string binding JSON values coerce to string without throwing. flutter analyze clean; flutter test 215/215 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
clevertap-heimdall
Bot
added
the
type/test-docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: SDK-6011 — epic SDK-5820
Stack (bottom → top):
Base of stack:
feat/SDK-5821-flutter-models(PR #38 →main).Stack created with GitHub Stacks CLI • Give Feedback 💬