SDK-6009: Flutter click + viewed attribution extras with element-clicked bridge - #77
Merged
CTLalit merged 1 commit intoAug 13, 2026
Conversation
…ked bridge Bring Flutter click/view attribution to parity with the shipped Android/iOS work (SDK-5793, SDK-5846). Previously only unitId + elementId reached Core SDK; the clicked action's context and the ND SDK version stamp were dropped. - ActionAttributionExtras: pure Dart helper that flattens an NDAction into a flat extras map (action_type + reserved action_* keys, spread metadata/ params/properties and CustomAction JsonObject value entries, action_value for scalars). sanitize() drops null/empty-key entries and stamps the ND SDK version (nd_lib_v_name/nd_lib_v_code). Mirrors the shipped Kotlin/Swift helper key-for-key. Client never injects wzrk_* (server-owned namespace). - NDSdkVersion: version constants kept in sync with pubspec (0.1.0 / 100), mirroring Android BuildConfig / iOS NativeDisplaySDKVersion. - NativeDisplayBridge.pushClickedEvent gains an optional extras map, forwarded as additionalProperties when non-empty; pushViewedEvent always forwards the version stamp (impressions are unit-level, no caller extras). - Button + IMAGE call sites build extras from the resolved onClick action. - Native plugins (Android Kotlin + iOS Swift): NativeDisplayPluginBridge pushClickedEvent/pushViewedEvent widened to carry additionalProperties; read from the MethodCall and forwarded to the host bridge (which forwards to the ND SDK's element-clicked / viewed-with-extras path). - Tests: 20 ActionAttributionExtras cases + bridge arg-shape assertions. flutter analyze clean; flutter test 183/183 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
clevertap-heimdall
Bot
added
the
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: SDK-6009 — epic SDK-5820
Stack (bottom → top):
Base of stack:
feat/SDK-5821-flutter-models(PR #38 →main).Stack created with GitHub Stacks CLI • Give Feedback 💬