Skip to content

fix: 대학 검색 키워드 시드 마이그레이션 보정 #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanooGwan merged 1 commit into from
Jun 1, 2026
Merged

fix: 대학 검색 키워드 시드 마이그레이션 보정 #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/resources/db/migration/V87__seed_university_search_keywords.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
-- Seed keywords only for universities that already exist in each environment.
-- This migration can be retried after flyway repair without duplicating existing keywords.
INSERT INTO university_search_keyword (university_id, keyword, normalized_keyword, keyword_type)
SELECT university.id, expected_keyword.keyword, expected_keyword.normalized_keyword, expected_keyword.keyword_type
FROM (
Expand Down Expand Up @@ -60,4 +62,7 @@ FROM (
UNION ALL SELECT '해군사관학교' AS university_name, '해사' AS keyword, '해사' AS normalized_keyword, 'ALIAS' AS keyword_type
UNION ALL SELECT '홍익대학교' AS university_name, '홍대' AS keyword, '홍대' AS normalized_keyword, 'ALIAS' AS keyword_type
) expected_keyword
LEFT JOIN university ON university.korean_name = expected_keyword.university_name;
JOIN university ON university.korean_name = expected_keyword.university_name
ON DUPLICATE KEY UPDATE
keyword = VALUES(keyword),
keyword_type = VALUES(keyword_type);
68 changes: 0 additions & 68 deletions src/main/resources/db/migration/V88__seed_existing_university_search_keywords.sql
View file
Open in desktop

This file was deleted.

21 changes: 3 additions & 18 deletions ...test/java/gg/agit/konect/unit/domain/university/UniversitySearchKeywordMigrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package gg.agit.konect.unit.domain.university;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

import java.sql.Connection;
import java.sql.SQLException;
Expand Down Expand Up @@ -95,27 +94,13 @@ AND keyword.keyword IN ('과기대', '서울과기대')
}

@Test
void failWhenSeedTargetUniversityIsMissing() throws Exception {
JdbcTemplate jdbcTemplate = createJdbcTemplate("seedMissingUniversity");
createUniversityTable(jdbcTemplate);
insertUniversities(jdbcTemplate, SEEDED_UNIVERSITY_NAMES.stream()
.filter(universityName -> !universityName.equals("한국기술교육대학교"))
.toList());
executeMigration(jdbcTemplate, "db/migration/V86__create_university_search_keyword.sql");

assertThatThrownBy(() ->
executeMigration(jdbcTemplate, "db/migration/V87__seed_university_search_keywords.sql"))
.isInstanceOf(Exception.class);
}

@Test
void seedExistingUniversitySearchKeywords() throws Exception {
JdbcTemplate jdbcTemplate = createJdbcTemplate("seedExistingUniversity");
void seedOnlyExistingUniversitySearchKeywords() throws Exception {
JdbcTemplate jdbcTemplate = createJdbcTemplate("seedOnlyExistingUniversity");
createUniversityTable(jdbcTemplate);
insertUniversities(jdbcTemplate, List.of("한국기술교육대학교"));
executeMigration(jdbcTemplate, "db/migration/V86__create_university_search_keyword.sql");

executeMigration(jdbcTemplate, "db/migration/V88__seed_existing_university_search_keywords.sql");
executeMigration(jdbcTemplate, "db/migration/V87__seed_university_search_keywords.sql");

Integer keywordCount = jdbcTemplate.queryForObject(
"SELECT COUNT(*) FROM university_search_keyword",
Expand Down
Loading