Skip to content

fix(terminal): restore focus after context menu dismiss (follow-up to #2948)#2966

Open
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:mainfrom
AllBeingsFuture:fix/2948-context-menu-focus
Open

fix(terminal): restore focus after context menu dismiss (follow-up to #2948)#2966
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:mainfrom
AllBeingsFuture:fix/2948-context-menu-focus

Conversation

@AllBeingsFuture

Copy link
Copy Markdown

Summary

Follow-up / re-host of #2948 with the review bug fixed.

Original head is AgentWrapper:ao/agent-orchestrator-37/terminal-context-menu; this account has pull-only on the upstream repo (403 on push). Fix is on AllBeingsFuture:fix/2948-context-menu-focus.

Fix

  • Always refocus xterm when the context menu closes (Escape / outside click), not only after menu item actions — prevents silent typing loss after Radix steals focus.

Includes original #2948 feature + fix commit 5402ca73.

Test plan

  • Right-click terminal → Escape → typing still reaches PTY without clicking
  • Copy / Paste / Select All / Clear still work
  • Frontend unit tests for context menu focus restore

@somewherelostt

Copy link
Copy Markdown
Collaborator

Thanks for contributing to Agent Orchestrator.

This PR is being picked up by the current external contributor on-call pair:

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @illegalcall and @Pulkit7070 here.

For faster context or live questions, you can also join the AO Discord.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.

Refocus xterm on any menu close (Escape/outside/action), align Clear
with CLEAR_SEQUENCE, and cover the dismiss/copy-enabled paths in tests.
@AllBeingsFuture
AllBeingsFuture force-pushed the fix/2948-context-menu-focus branch from 5402ca7 to 79ac108 Compare July 23, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants