Skip to content

fix: restore terminal focus after context menu dismiss#2962

Closed
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:ao/agent-orchestrator-37/terminal-context-menufrom
AllBeingsFuture:ao/agent-orchestrator-37/terminal-context-menu
Closed

fix: restore terminal focus after context menu dismiss#2962
AllBeingsFuture wants to merge 1 commit into
AgentWrapper:ao/agent-orchestrator-37/terminal-context-menufrom
AllBeingsFuture:ao/agent-orchestrator-37/terminal-context-menu

Conversation

@AllBeingsFuture

Copy link
Copy Markdown

Summary

Follow-up fix for #2948 review findings:

  • Restore xterm focus on any context-menu dismiss (Escape / outside click / action), not only after menu item actions
  • Align Clear with CLEAR_SEQUENCE used by AttachableTerminal.clear
  • Tests: Escape dismiss refocuses terminal; Copy enabled when selection exists

Tests

  • npx -y node@22.12.0 ./node_modules/vitest/vitest.mjs run --config vite.renderer.config.ts XtermTerminal.test.tsx (40 passed)
  • npm run typecheck (frontend)

Stacked onto #2948 head branch because this account cannot push to AgentWrapper/agent-orchestrator directly.

Refocus xterm on any menu close (Escape/outside/action), align Clear
with CLEAR_SEQUENCE, and cover the dismiss/copy-enabled paths in tests.
@somewherelostt

Copy link
Copy Markdown
Collaborator

Thanks for contributing to Agent Orchestrator.

This PR is being picked up by the current external contributor on-call pair:

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @illegalcall and @Pulkit7070 here.

For faster context or live questions, you can also join the AO Discord.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.

@AllBeingsFuture

Copy link
Copy Markdown
Author

Closing as superseded by #2966 (correct tip / base on main after #2948). Keeper is #2966.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants