Skip to content

fix: add missing required flags to instance create help texts #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ditahkk merged 1 commit into from
Jul 7, 2026
Merged

fix: add missing required flags to instance create help texts #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/commands/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,9 @@ func newInstanceCreateCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "create",
Short: "Create a new virtual machine",
Example: ` zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly
zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly --wait
zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly --ssh-key mykey # import the key first with 'zcp ssh-key import'`,
Example: ` zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly --network-plan pnet-yul --storage-category premium-ssd
zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly --network-plan pnet-yul --storage-category premium-ssd --wait
zcp instance create --name my-vm --project default-9 --region yul-1 --template ubuntu-2604-lts-1 --plan ca2sl --billing-cycle hourly --network-plan pnet-yul --storage-category premium-ssd --ssh-key mykey # import the key first with 'zcp ssh-key import'`,
RunE: func(cmd *cobra.Command, args []string) error {
if name == "" {
return fmt.Errorf("--name is required")
Expand All @@ -384,6 +384,12 @@ func newInstanceCreateCmd() *cobra.Command {
if billingCycle == "" {
return fmt.Errorf("--billing-cycle is required")
}
if storageCategory == "" {
return fmt.Errorf("--storage-category is required")
}
if networkPlan == "" {
return fmt.Errorf("--network-plan is required")
}
if userData != "" && userDataFile != "" {
return fmt.Errorf("--user-data and --user-data-file are mutually exclusive")
}
Expand Down Expand Up @@ -479,10 +485,10 @@ func newInstanceCreateCmd() *cobra.Command {
cmd.Flags().StringVar(&networkType, "network-type", "Isolated", "Network type (default: Isolated)")
cmd.Flags().StringVar(&sshKey, "ssh-key", "", "Name of an existing SSH key to attach for login (optional; see 'zcp ssh-key list')")
cmd.Flags().StringVar(&hostname, "hostname", "", "Hostname (defaults to --name)")
cmd.Flags().StringVar(&storageCategory, "storage-category", "", "Storage category slug (optional)")
cmd.Flags().StringVar(&storageCategory, "storage-category", "", "Storage category (required, e.g. premium-ssd - see: zcp plan storage)")
cmd.Flags().StringVar(&computeCategory, "compute-category", "", "Compute category slug (optional)")
cmd.Flags().StringVar(&blockstoragePlan, "blockstorage-plan", "", "Block storage plan slug (optional, e.g. b2g1 — see: zcp plan storage)")
cmd.Flags().StringVar(&networkPlan, "network-plan", "", "Network plan slug (e.g. pnet-yow, pnet-yul — see: zcp plan network)")
cmd.Flags().StringVar(&networkPlan, "network-plan", "", "Network plan slug (required, e.g. pnet-yow, pnet-yul — see: zcp plan network)")
cmd.Flags().StringVar(&userData, "user-data", "", "Startup script content (cloud-init / bash)")
cmd.Flags().StringVar(&userDataFile, "user-data-file", "", "Path to a file containing the startup script")
cmd.Flags().IntVar(&cpu, "cpu", 0, "Number of vCPUs for a custom plan (e.g. 2)")
Expand Down
Loading